search

faiface / beep

A little package that brings sound to any Go application. Suitable for playback and audio-processing.
MIT License
2.08k stars 151 forks source link

Pcm #109

Closed crazybber closed 3 years ago

crazybber commented 3 years ago

merge pcm

makew0rld commented 3 years ago

This looks identical to #105 which @icholy closed, saying it wasn't ready. What makes yours different?

dusk125 commented 3 years ago

This looks identical to #105 which @icholy closed, saying it wasn't ready. What makes yours different?

@crazybber Can you comment on this please?

ashutoshgngwr commented 3 years ago

@dusk125 These are the same commits from the original PR (#105), and thus incomplete.

dusk125 commented 3 years ago

Sorry, definitely missed that these are just the same commits, I thought crazybber had implemented/reimplemented it. Given that this is the same and icholy said they would reopen when it was ready, I'm going to close this PR. @crazybber, if you have changes you would like to contribute to this issue, please feel free to reopen this PR with your additional changes.

icholy commented 3 years ago

I ended up rewriting that PCM handling code specifically for a live streaming scenario I had. I was hoping that I could create a general purpose version that would also work for my use case. Now I'm not sure if that's actually possible (the smallest buffering changes have huge impacts). I'd be more inclined to add some example code showing how to use encode/decode PCM rather than including actual encoder/decoder implementations.