search

faiface / beep

A little package that brings sound to any Go application. Suitable for playback and audio-processing.
MIT License
2.08k stars 151 forks source link

add sinusoid tone generation #127

Closed ilyapashuk closed 3 years ago

ilyapashuk commented 3 years ago

closes #126

dusk125 commented 3 years ago

Thanks for the PR, I just have a couple comments/suggestions.

It looks like a linter hasn't been run on the code; there are no indentions. Please run this through the go linter and update the PR. Also could you please move this file into its own sub-package, something like 'generators'? I can imagine we might want other generators, Square, Triangle, Noise in the future.

dusk125 commented 3 years ago

Thanks for the changes, looks good!