search

faiface / beep

A little package that brings sound to any Go application. Suitable for playback and audio-processing.
MIT License
2.07k stars 152 forks source link

Detect NumChannels during ogg/vorbis decode #139

Closed gabe565 closed 1 year ago

gabe565 commented 2 years ago

The current vorbis decoder sets NumChannels to 2 even though jfreymuth/oggvorbis provides a way to determine a vorbis stream's number of channels.

This is working in my testing, but if this was hardcoded to 2 for a reason then feel free to close this PR.

samhocevar commented 1 year ago

Hello! Unfortunately this is not enough because you also need to fix Stream() which expects stereo data. I only noticed your PR today but I had already submitted #154 some time ago, which hopefully addresses the whole issue.

gabe565 commented 1 year ago

Oh nice catch. Closing in favor of #154