search

fails-components / webtransport

Http/3 webtransport support for node
Other
146 stars 20 forks source link

fix generating TypeScript type definitions #236

Closed endel closed 8 months ago

endel commented 8 months ago

Hi @martenrichter,

I've made some changes to tsconfig.json and changed to generate type definitions only before publishing (prepublishOnly)

I'm still getting used to the codebase, let me know if I'm missing something.

Before

Screenshot 2023-12-31 at 10 32 22 Screenshot 2023-12-31 at 10 32 07

After

image image

All the best and happy new year ✨

martenrichter commented 8 months ago

Also happy new year to you! (In a couple of hours I suppose). Regarding the change, I actually would like to keep the "types" command, so that I can verify, that the types are ok, before I hit The rest I will comment within the commit.

endel commented 8 months ago

Thanks for the review, I've just updated bringing back the "types" script and removing the prepublishOnly, I believe publishing should work as before now 🙌

martenrichter commented 8 months ago

Ok, I will then hit the CI/CD jobs to see if they run, and maybe merge it later. I will probably wait for a release (or do the types not work at all?) until another issue pops up.