fails-components / webtransport

Http/3 webtransport support for node
Other
132 stars 20 forks source link

fix: test that quicheLogVerbose is a number #263

Closed achingbrain closed 4 months ago

achingbrain commented 4 months ago

According to the types quicheLogVerbose when passed as an option should be a number, the test here asserts it's a function, so it's not possible to enable verbose quiche logging.

achingbrain commented 4 months ago

@martenrichter any idea what the number should be to get quiche to output something?

martenrichter commented 4 months ago

If I remember correctly, an integer 1,2,3 for the different levels. But I think it is coming through stderr, stdout. I can not remember if I programmed a redirect to the javascript console, I wanted.

achingbrain commented 4 months ago

Hmm, I still don't see anything in the terminal - I can see the output of printf lines I put in the c++ code, so I would have thought I'd see some quiche log output if this option does what it's supposed to do.

martenrichter commented 4 months ago

It may be stderr, you have to look at the absl logging impl.

achingbrain commented 4 months ago

I don't think stderr would be hidden, I'm running things using the node cli in zsh, stdout and stderr appear as expected but nothing from quiche.

martenrichter commented 4 months ago

Then I do not know, it may be broken. So, I may have used it before the reorganization. I can look into it..., but it does not seem that I redirected the log output... Most times I use print for diagnosis for the stuff that I need.