failsafe-lib / failsafe

Fault tolerance and resilience patterns for the JVM
https://failsafe.dev
Apache License 2.0
4.16k stars 295 forks source link

CircuitBreakerBuilder withSuccessThreshold documentation whoopsy #384

Closed GalBachar closed 2 months ago

GalBachar commented 2 months ago

https://github.com/failsafe-lib/failsafe/blob/ceb14ace0c665a7a7fef1d0440c14d7122423343/core/src/main/java/dev/failsafe/CircuitBreakerBuilder.java#L274

Should say: The number of consecutive successful executions that must occur in order to close the circuit

jhalterman commented 2 months ago

Thanks for pointing this out.