Closed wirew0rm closed 1 year ago
As per discussion on June 21 with Alex and updated July 21.
Deterministic layout and hierarchy changes
Smaller changes that would be better in a separate PR.
I think the goals have all been achieved and are ready for review. The style nodes ended up not being necessary.
Below are some before and after pictures
Before | After | Comment |
---|---|---|
The chart anatomy parts can still be fully accessed, but without the need for StackPane wrappers | ||
All of the extra layout panes were removed and have been replaced with a small hierarchy of custom panes. Axis layouts are now deterministic and can be done without recursion. | ||
labels don't disapper when resizing | ||
tick label spacing is now computed correctly | ||
disabled ranges now correctly remove the invalid tick labels (bottom left) | ||
enabling an axis does not break the label positioning anymore | ||
all rotations and overlap strategies get correctly rendered |
Most importantly, the data rendered on the chart is now always consistent with the value shown on the axes.
Here is a video of one of our applications that used to have significant rendering issues: Deterministic Layout PR
Goals:
Chart
componentItems to be investigated implemented: