A scientific charting library focused on performance optimised real-time data visualisation at 25 Hz update rates for data sets with a few 10 thousand up to 5 million data points.
GNU Lesser General Public License v3.0
504
stars
93
forks
source link
Change CachedDataPoints access modifier to public #613
Describe the bug
Classes that extend the ErrorDataSetRenderer and override any of the draw*(GraphicsContext, CachedDataPoints): void methods must be placed in the same package (de.gsi.chart.renderer.spi or io.fair_acc.chartfx.renderer.spi) because CachedDataPoints has only package private class access and is exposed outside of its defined visibility scope.
If there are no objections, we should change the access modifier to public. This will make it easier to customize the error data set renderer and to avoid split packages.
Let me know if you are interested in a PR for this small change.
Describe the bug Classes that extend the ErrorDataSetRenderer and override any of the
draw*(GraphicsContext, CachedDataPoints): voidmethods must be placed in the same package (de.gsi.chart.renderer.spiorio.fair_acc.chartfx.renderer.spi) because CachedDataPoints has only package private class access and is exposed outside of its defined visibility scope. If there are no objections, we should change the access modifier to public. This will make it easier to customize the error data set renderer and to avoid split packages. Let me know if you are interested in a PR for this small change.Environment: