fair-acc / chart-fx

A scientific charting library focused on performance optimised real-time data visualisation at 25 Hz update rates for data sets with a few 10 thousand up to 5 million data points.
GNU Lesser General Public License v3.0
508 stars 94 forks source link

Simplify extending the ErrorDataSetRenderer #615

Closed TheBoegl closed 1 year ago

TheBoegl commented 1 year ago

This commit changes the access modifier for the CachedDataPoints class to public and fixes #613. It also makes it easier to customize the error data set renderer and avoids split packages.

pr-explainer-bot[bot] commented 1 year ago

Pull Request Report

Greetings! πŸ‘‹

Here's a report summarizing the changes, suggestions, bugs, improvements, and rating for the pull request.

Changes

  1. Changed the access modifier for the CachedDataPoints class from package private to public. (Link to file)

Suggestions

No suggestions provided.

Bugs

No bugs found.

Improvements

No improvements suggested.

Rating

Overall rating: 8/10

Criteria:

That's it for the report! Let me know if you need any further assistance. πŸ˜„

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01% :tada:

Comparison is base (3846311) 47.90% compared to head (10c5ffd) 47.91%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #615 +/- ## ============================================ + Coverage 47.90% 47.91% +0.01% - Complexity 6181 6183 +2 ============================================ Files 401 401 Lines 38254 38254 Branches 6087 6087 ============================================ + Hits 18326 18331 +5 Misses 18778 18778 + Partials 1150 1145 -5 ``` | [Files Changed](https://app.codecov.io/gh/fair-acc/chart-fx/pull/615?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fair-acc) | Coverage Ξ” | | |---|---|---| | [...air\_acc/chartfx/renderer/spi/CachedDataPoints.java](https://app.codecov.io/gh/fair-acc/chart-fx/pull/615?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fair-acc#diff-Y2hhcnRmeC1jaGFydC9zcmMvbWFpbi9qYXZhL2lvL2ZhaXJfYWNjL2NoYXJ0ZngvcmVuZGVyZXIvc3BpL0NhY2hlZERhdGFQb2ludHMuamF2YQ==) | `38.98% <100.00%> (ΓΈ)` | | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/fair-acc/chart-fx/pull/615/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fair-acc)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.