wirew0rm commented 9 months ago

bump the main java version from 11 to 17 and add a 21 build.
bump javafx to 16
- all later versions trigger the memory leak check in our unittests. I followed it up to it being triggered by charts having at least one plugin, while an anonymous ChartPlugin does not trigger it. It seems to be triggered by the listener on the chartProperty having references to the chart in its Closure.
bump all other plugin references
- except javadoc, which causes jigsaw/module-system related errors if updated to the most recent version.
update github actions to current versions.
address leftovers from the previous PRs
- Measurements: remove unused indicators
- UpdateAxisPlugin: disable for now since it was not completely implemented anyhow and has to be adapted to the event system
- EditDataSet: recompute selector ui element positions on axis or data changes
- CategoryAxis: reenable updating the labels from dataset labels

pr-explainer-bot[bot] commented 9 months ago

Pull Request Report

Hey there! 👋 Here's a report on the changes, suggestions, bugs, improvements, and rating for the pull request.

Changes

Updated JAVA_REFERENCE_VERSION environment variable from 11 to 17 in .github/workflows/ci.yml.
Added a new build for Java 21 in .github/workflows/ci.yml.
Updated the actions/checkout version from v2 to v3 in .github/workflows/ci.yml and .github/workflows/coverity.yml.
Updated the actions/cache version from v1 to v3 in .github/workflows/coverity.yml.
Updated the actions/setup-java version from v2.1.0 to v3 in .github/workflows/coverity.yml.
Updated the version of testfx-junit5 dependency from 4.0.16-alpha to 4.0.17 in chartfx-chart/pom.xml.
Updated the version of maven-plugin-api dependency from 3.6.3 to 3.9.4 in chartfx-generate/pom.xml.
Updated the version of maven-plugin-annotations dependency from 3.6.0 to 3.9.0 in chartfx-generate/pom.xml.
Updated the version of jafama dependency from 2.3.1 to 2.3.2 in chartfx-math/pom.xml and chartfx-samples/pom.xml.
Updated the maven.compiler.source and maven.compiler.target versions from 11 to 17 in pom.xml.
Updated the version of commons-lang3 dependency from 3.12.0 to 3.13.0 in pom.xml.
Updated the version of slf4j dependency from 2.0.6 to 2.0.9 in pom.xml.
Updated the version of junit.jupiter dependency from 5.9.2 to 5.10.0 in pom.xml.
Updated the version of jetbrains.annotations dependency from 21.0.1 to 24.0.1 in pom.xml.
Updated the version of JMemoryBuddy dependency from 0.2.6 to 0.5.2 in pom.xml.

Suggestions

Consider providing more detailed commit messages to improve readability and understanding of the changes made.

Bugs

No bugs found.

Improvements

Refactor the code in a few places for better readability:

In chartfx-chart/pom.xml, update the testfx-junit5 version to 4.0.17:

<dependency>
<groupId>org.testfx</groupId>
<artifactId>testfx-junit5</artifactId>
<version>4.0.17</version>
<scope>test</scope>
</dependency>

In chartfx-generate/pom.xml, update the maven-plugin-api version to 3.9.4:

<dependency>
<groupId>org.apache.maven</groupId>
<artifactId>maven-plugin-api</artifactId>
<version>3.9.4</version>
</dependency>

In chartfx-math/pom.xml and chartfx-samples/pom.xml, update the jafama version to 2.3.2:

<dependency>
<groupId>net.jafama</groupId>
<artifactId>jafama</artifactId>
<version>2.3.2</version>
<scope>test</scope>
</dependency>

In pom.xml, update the commons-lang3 version to 3.13.0:
```
<version.commons-lang3>3.13.0</version.commons-lang3>
```
Update the `

codecov[bot] commented 9 months ago

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (77a2a8c) 48.04% compared to head (2599a44) 48.11%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #621 +/- ## ============================================ + Coverage 48.04% 48.11% +0.07% - Complexity 6200 6218 +18 ============================================ Files 374 374 Lines 38279 38299 +20 Branches 6102 6110 +8 ============================================ + Hits 18391 18428 +37 + Misses 18739 18720 -19 - Partials 1149 1151 +2 ``` | [Files](https://app.codecov.io/gh/fair-acc/chart-fx/pull/621?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fair-acc) | Coverage Δ | | |---|---|---| | [.../io/fair\_acc/chartfx/plugins/UpdateAxisLabels.java](https://app.codecov.io/gh/fair-acc/chart-fx/pull/621?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fair-acc#diff-Y2hhcnRmeC1jaGFydC9zcmMvbWFpbi9qYXZhL2lvL2ZhaXJfYWNjL2NoYXJ0ZngvcGx1Z2lucy9VcGRhdGVBeGlzTGFiZWxzLmphdmE=) | `0.00% <ø> (ø)` | | | [...ins/measurements/utils/ValueIndicatorSelector.java](https://app.codecov.io/gh/fair-acc/chart-fx/pull/621?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fair-acc#diff-Y2hhcnRmeC1jaGFydC9zcmMvbWFpbi9qYXZhL2lvL2ZhaXJfYWNjL2NoYXJ0ZngvcGx1Z2lucy9tZWFzdXJlbWVudHMvdXRpbHMvVmFsdWVJbmRpY2F0b3JTZWxlY3Rvci5qYXZh) | `94.59% <100.00%> (-0.08%)` | :arrow_down: | | [.../java/io/fair\_acc/chartfx/plugins/EditDataSet.java](https://app.codecov.io/gh/fair-acc/chart-fx/pull/621?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fair-acc#diff-Y2hhcnRmeC1jaGFydC9zcmMvbWFpbi9qYXZhL2lvL2ZhaXJfYWNjL2NoYXJ0ZngvcGx1Z2lucy9FZGl0RGF0YVNldC5qYXZh) | `24.66% <75.00%> (+1.17%)` | :arrow_up: | | [...in/java/io/fair\_acc/chartfx/renderer/Renderer.java](https://app.codecov.io/gh/fair-acc/chart-fx/pull/621?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fair-acc#diff-Y2hhcnRmeC1jaGFydC9zcmMvbWFpbi9qYXZhL2lvL2ZhaXJfYWNjL2NoYXJ0ZngvcmVuZGVyZXIvUmVuZGVyZXIuamF2YQ==) | `57.14% <0.00%> (-2.12%)` | :arrow_down: | | [...\_acc/chartfx/renderer/spi/AbstractRendererXYZ.java](https://app.codecov.io/gh/fair-acc/chart-fx/pull/621?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fair-acc#diff-Y2hhcnRmeC1jaGFydC9zcmMvbWFpbi9qYXZhL2lvL2ZhaXJfYWNjL2NoYXJ0ZngvcmVuZGVyZXIvc3BpL0Fic3RyYWN0UmVuZGVyZXJYWVouamF2YQ==) | `68.75% <0.00%> (-2.22%)` | :arrow_down: | | [...plugins/measurements/AbstractChartMeasurement.java](https://app.codecov.io/gh/fair-acc/chart-fx/pull/621?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fair-acc#diff-Y2hhcnRmeC1jaGFydC9zcmMvbWFpbi9qYXZhL2lvL2ZhaXJfYWNjL2NoYXJ0ZngvcGx1Z2lucy9tZWFzdXJlbWVudHMvQWJzdHJhY3RDaGFydE1lYXN1cmVtZW50LmphdmE=) | `77.45% <77.77%> (-0.77%)` | :arrow_down: | | [...r\_acc/chartfx/renderer/spi/AbstractRendererXY.java](https://app.codecov.io/gh/fair-acc/chart-fx/pull/621?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fair-acc#diff-Y2hhcnRmeC1jaGFydC9zcmMvbWFpbi9qYXZhL2lvL2ZhaXJfYWNjL2NoYXJ0ZngvcmVuZGVyZXIvc3BpL0Fic3RyYWN0UmVuZGVyZXJYWS5qYXZh) | `84.37% <62.50%> (-3.35%)` | :arrow_down: | | [...art/src/main/java/io/fair\_acc/chartfx/XYChart.java](https://app.codecov.io/gh/fair-acc/chart-fx/pull/621?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fair-acc#diff-Y2hhcnRmeC1jaGFydC9zcmMvbWFpbi9qYXZhL2lvL2ZhaXJfYWNjL2NoYXJ0ZngvWFlDaGFydC5qYXZh) | `57.03% <33.33%> (-1.11%)` | :arrow_down: | ... and [7 files with indirect coverage changes](https://app.codecov.io/gh/fair-acc/chart-fx/pull/621/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fair-acc)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.