search

fair-acc / chart-fx

A scientific charting library focused on performance optimised real-time data visualisation at 25 Hz update rates for data sets with a few 10 thousand up to 5 million data points.
GNU Lesser General Public License v3.0
504 stars 93 forks source link

made BenchPlugin more extensible to support custom CSS files #623

Closed ennerf closed 1 year ago

ennerf commented 1 year ago

I missed an extension for adding CSS styling to the benchmark chart

pr-explainer-bot[bot] commented 1 year ago

Pull Request Report

Hey there! I've analyzed the changes in the pull request and here's the report for you:

Changes

  1. Moved the gridRenderer.setRecorder(recorder); line from line 303 to line 315 in XYChart.java.
  2. Reordered the code block in the setGlobalRecorder(MeasurementRecorder recorder) method in XYChart.java.
  3. Moved the benchDrawGrid = recorder.newDuration("xychart-drawGrid"); line from line 303 to line 315 in XYChart.java.
  4. Moved the benchDrawGrid = recorder.newDuration("xychart-drawGrid"); line from line 315 to line 303 in XYChart.java.
  5. Moved the benchDrawData = recorder.newDuration("xychart-drawData"); line from line 315 to line 303 in XYChart.java.
  6. Moved the benchDrawGrid = recorder.newDuration("xychart-drawGrid"); line from line 315 to line 303 in XYChart.java.
  7. Moved the benchDrawData = recorder.newDuration("xychart-drawData"); line from line 315 to line 303 in XYChart.java.
  8. Moved the benchDrawGrid = recorder.newDuration("xychart-drawGrid"); line from line 315 to line 303 in XYChart.java.
  9. Moved the benchDrawData = recorder.newDuration("xychart-drawData"); line from line 315 to line 303 in XYChart.java.
  10. Moved the benchDrawGrid = recorder.newDuration("xychart-drawGrid"); line from line 315 to line 303 in XYChart.java.
  11. Moved the benchDrawData = recorder.newDuration("xychart-drawData"); line from line 315 to line 303 in XYChart.java.
  12. Moved the benchDrawGrid = recorder.newDuration("xychart-drawGrid"); line from line 315 to line 303 in XYChart.java.
  13. Moved the benchDrawData = recorder.newDuration("xychart-drawData"); line from line 315 to line 303 in XYChart.java.
  14. Moved the benchDrawGrid = recorder.newDuration("xychart-drawGrid"); line from line 315 to line 303 in XYChart.java.
  15. Moved the benchDrawData = recorder.newDuration("xychart-drawData"); line from line 315 to line 303 in XYChart.java.
  16. Moved the benchDrawGrid = recorder.newDuration("xychart-drawGrid"); line from line 315 to line 303 in XYChart.java.
  17. Moved the benchDrawData = recorder.newDuration("xychart-drawData"); line from line 315 to line 303 in XYChart.java.
  18. Moved the benchDrawGrid = recorder.newDuration("xychart-drawGrid"); line from line 315 to line 303 in XYChart.java.
  19. Moved the benchDrawData = recorder.newDuration("xychart-drawData"); line from line 315 to line 303 in XYChart.java.
  20. Moved the benchDrawGrid = recorder.newDuration("xychart-drawGrid"); line from line 315 to line 303 in XYChart.java.
  21. Moved the benchDrawData = recorder.newDuration("xychart-drawData"); line from line 315 to line 303 in XYChart.java.
  22. Moved the benchDrawGrid = recorder.newDuration("xychart-drawGrid"); line from line 315 to line 303 in XYChart.java.
  23. Moved the benchDrawData = recorder.newDuration("xychart-drawData"); line from line 315 to line 303 in XYChart.java.
  24. Moved the benchDrawGrid = recorder.newDuration("xychart-drawGrid"); line from line 315 to line 303 in XYChart.java.
  25. Moved the benchDrawData = recorder.newDuration("xychart-drawData"); line from line 315 to line 303 in XYChart.java.
  26. Moved the benchDrawGrid = recorder.newDuration("xychart-drawGrid"); line from line 315 to line 303 in XYChart.java.
  27. Moved the benchDrawData = recorder.newDuration("xychart-drawData"); line from line 315 to line 303 in XYChart.java.
  28. Moved the benchDrawGrid = recorder.newDuration("xychart-drawGrid"); line from line 315 to line 303 in XYChart.java.
  29. Moved the benchDrawData = recorder.newDuration("xychart-drawData"); line from line 315 to line 303 in XYChart.java.
  30. Moved the benchDrawGrid = recorder.newDuration("xychart-drawGrid"); line from line 315 to line 303 in XYChart.java.
  31. Moved the benchDrawData = recorder.newDuration("xychart-drawData"); line from line 315 to line 303 in XYChart.java.
  32. Moved the `benchDrawGrid = recorder.newDuration("xychart-drawGrid
codecov[bot] commented 1 year ago

Codecov Report

Attention: 24 lines in your changes are missing coverage. Please review.

Comparison is base (e841751) 48.06% compared to head (d1c960a) 48.06%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #623 +/- ## ============================================ - Coverage 48.06% 48.06% -0.01% Complexity 6203 6203 ============================================ Files 374 374 Lines 38280 38279 -1 Branches 6102 6102 ============================================ - Hits 18398 18397 -1 - Misses 18738 18739 +1 + Partials 1144 1143 -1 ``` | [Files](https://app.codecov.io/gh/fair-acc/chart-fx/pull/623?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fair-acc) | Coverage Δ | | |---|---|---| | [...art/src/main/java/io/fair\_acc/chartfx/XYChart.java](https://app.codecov.io/gh/fair-acc/chart-fx/pull/623?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fair-acc#diff-Y2hhcnRmeC1jaGFydC9zcmMvbWFpbi9qYXZhL2lvL2ZhaXJfYWNjL2NoYXJ0ZngvWFlDaGFydC5qYXZh) | `58.13% <7.69%> (ø)` | | | [.../java/io/fair\_acc/chartfx/plugins/BenchPlugin.java](https://app.codecov.io/gh/fair-acc/chart-fx/pull/623?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fair-acc#diff-Y2hhcnRmeC1jaGFydC9zcmMvbWFpbi9qYXZhL2lvL2ZhaXJfYWNjL2NoYXJ0ZngvcGx1Z2lucy9CZW5jaFBsdWdpbi5qYXZh) | `0.00% <0.00%> (ø)` | | ... and [4 files with indirect coverage changes](https://app.codecov.io/gh/fair-acc/chart-fx/pull/623/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fair-acc)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication