fair-acc / chart-fx

A scientific charting library focused on performance optimised real-time data visualisation at 25 Hz update rates for data sets with a few 10 thousand up to 5 million data points.
GNU Lesser General Public License v3.0
488 stars 90 forks source link

Initial zoom in Zoomer is incorrect #660

Closed ToniMarc1990 closed 4 months ago

ToniMarc1990 commented 4 months ago
codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 48.06%. Comparing base (ed86318) to head (2ea0ced). Report is 1 commits behind head on main.

Files Patch % Lines
.../main/java/io/fair_acc/chartfx/plugins/Zoomer.java 0.00% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #660 +/- ## ============================================ - Coverage 48.08% 48.06% -0.02% - Complexity 6220 6221 +1 ============================================ Files 374 374 Lines 38309 38309 Branches 6117 6117 ============================================ - Hits 18419 18415 -4 - Misses 18732 18735 +3 - Partials 1158 1159 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 4 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

ToniMarc1990 commented 4 months ago

LGTM, thanks again for contributing.

Since #636 describes multiple problems, does this fix only one aspects or are they all caused by this root cause? Otherwise i'll investigate and update the issue.

@wirew0rm: Thanks for merging this fix. When is the next planned/unplanned release? We want to integrate ChartFX in our application and thus need this fix ASAP.

RalphSteinhagen commented 4 months ago

@ToniMarc1990 we certainly can target a release soon.

May I ask you for a favour: You seem to indicate that you are using ChartFX in an industrial setting which we are happy to support. We are continuously looking into fostering a more robust community around ChartFX without intruding on user privacy or application purposes.

To highlight ChartFX's versatility and advocate for continuing public support, we would like to gather user stories, applications, and companies without implying any endorsement or financial commitment from said author/company/team.

Would you/your company be willing to contribute by sharing:

Your input will be invaluable in showcasing real-world applications and securing resources for ChartFX's growth. The primary purpose is to highlight the many diverse applications of ChartFX and the JavaFX eco-system in general and to demonstrate how we use public resources to benefit not only GSI/FAIR but also industry and academia alike.

There are many nay-sayers who claim that engaging with the public costs more than it benefits -- which we'd like to dispel.

We are aware that being the first in any list is always the hardest. Thus, we would first collect public support from about a dozen companies/institutes before setting up a sub-page. Please reach out on our matrix channel or via fair-c2-admin@gsi.de if you prefer.

N.B. The matrix channel is also a good place to get in contact with the other ChartFX developers in a more timely and inclusive manner.

ToniMarc1990 commented 3 months ago

@ToniMarc1990 we certainly can target a release soon.

May I ask you for a favour: You seem to indicate that you are using ChartFX in an industrial setting which we are happy to support. We are continuously looking into fostering a more robust community around ChartFX without intruding on user privacy or application purposes.

To highlight ChartFX's versatility and advocate for continuing public support, we would like to gather user stories, applications, and companies without implying any endorsement or financial commitment from said author/company/team.

Would you/your company be willing to contribute by sharing:

  • Your company name, logo and domain of operation (robotics, medical, finance, research, ...).
  • A brief description of how you use ChartFX.
  • Screenshots showing ChartFX in your projects (sans sensitive info).
  • Any public links or materials featuring ChartFX.

Your input will be invaluable in showcasing real-world applications and securing resources for ChartFX's growth. The primary purpose is to highlight the many diverse applications of ChartFX and the JavaFX eco-system in general and to demonstrate how we use public resources to benefit not only GSI/FAIR but also industry and academia alike.

There are many nay-sayers who claim that engaging with the public costs more than it benefits -- which we'd like to dispel.

We are aware that being the first in any list is always the hardest. Thus, we would first collect public support from about a dozen companies/institutes before setting up a sub-page. Please reach out on our matrix channel or via fair-c2-admin@gsi.de if you prefer.

N.B. The matrix channel is also a good place to get in contact with the other ChartFX developers in a more timely and inclusive manner.

@RalphSteinhagen : We are interested in sharing information about us and the usage of ChartFX in our product. I forwarded the inquiry to my manager.

ichaus-we commented 3 months ago

Since #636 describes multiple problems, does this fix only one aspects or are they all caused by this root cause? Otherwise i'll investigate and update the issue.

Thanks for the new release. Problem 1 (of 4) is fixed by this. See my update in #636

RalphSteinhagen commented 3 months ago

@ichaus-we have the same request: You seem to be using ChartFX in an industrial context. Would your company be willing to share details about its domain, example applications/screenshots, and be mentioned (Logo, Name) as one of the libs users?

This would help us a lot with building a strong(er) user base and long-term maintenance commitment.

Thanks in advance for your consideration.