search

fair-acc / chart-fx

A scientific charting library focused on performance optimised real-time data visualisation at 25 Hz update rates for data sets with a few 10 thousand up to 5 million data points.
GNU Lesser General Public License v3.0
508 stars 94 forks source link

Fix update of line dashes #672

Closed protogenes closed 3 months ago

protogenes commented 3 months ago

Changing Number[] lineDashArrayProperty will not update the binding double[] lineDashesProperty which is used by the renderer (via StyleUtils), thus any change will never be shown on screen.

This is just a quick fix, in my opinion it would be better to remove lineDashesProperty and use some variant of toLineDashArray to convert the Number[] when rendering

sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud