ChartPlugin scene listener is not removed

fair-acc / chart-fx

A scientific charting library focused on performance optimised real-time data visualisation at 25 Hz update rates for data sets with a few 10 thousand up to 5 million data points.

GNU Lesser General Public License v3.0

508 stars 94 forks source link

ChartPlugin scene listener is not removed #676

Closed amischler closed 1 month ago

amischler commented 2 months ago

The ChartPlugin register a listener on some of its nodes sceneProperty but those listeners are never being removed, even when the plugin is removed from a chart (i.e. chart property of the Plugin is set to null).

In some cases, a ChartPlugin that is not in any chart might still receive Scene events, which should not be the case.

See ChartPluginTest in this PR for more details.

sonarcloud[bot] commented 2 months ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

amischler commented 1 month ago

Thank you for merging and BTW thank you for this great library!