fair-acc / gnuradio4

Prototype implementations for a more compile-time efficient flowgraph API
GNU Lesser General Public License v3.0
22 stars 8 forks source link

Implement CtxSettings, use instead of BasicSettings. #346

Closed drslebedev closed 1 month ago

drslebedev commented 1 month ago

This PR includes the implementation of CtxSettings, which will replace the existing BasicSettings.

Several tasks need to be addressed following this PR to fully integrate CtxSettings into the codebase: 1) Remove Base Settings Class and BasicSettings. The old BasicSettings and its base class need to be removed to eliminate redundancy and avoid confusion. 2) Eliminate usage of unique_ptr for Block::_settings 3) Update function names to clearly indicate they are associated with CtxSettings, enhancing code readability. 4) Expand Unit Testing. Add comprehensive unit tests specifically targeting CtxSettings . 5) using MatchPredicate = std::function<std::optional<bool>(const pmtv::pmt &, const pmtv::pmt &, std::size_t)>; replace this with the new matcher structure. See here for details.

sonarcloud[bot] commented 1 month ago

Quality Gate Failed Quality Gate failed

Failed conditions
12.5% Coverage on New Code (required ≥ 80%)
5.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud