This PR includes the implementation of CtxSettings, which will replace the existing BasicSettings.
Several tasks need to be addressed following this PR to fully integrate CtxSettings into the codebase:
1) Remove Base Settings Class and BasicSettings. The old BasicSettings and its base class need to be removed to eliminate redundancy and avoid confusion.
2) Eliminate usage of unique_ptr for Block::_settings
3) Update function names to clearly indicate they are associated with CtxSettings, enhancing code readability.
4) Expand Unit Testing. Add comprehensive unit tests specifically targeting CtxSettings .
5) using MatchPredicate = std::function<std::optional<bool>(const pmtv::pmt &, const pmtv::pmt &, std::size_t)>;
replace this with the new matcher structure. See here for details.
This PR includes the implementation of
CtxSettings
, which will replace the existingBasicSettings
.Several tasks need to be addressed following this PR to fully integrate
CtxSettings
into the codebase: 1) Remove Base Settings Class andBasicSettings
. The oldBasicSettings
and its base class need to be removed to eliminate redundancy and avoid confusion. 2) Eliminate usage ofunique_ptr
for Block::_settings 3) Update function names to clearly indicate they are associated withCtxSettings
, enhancing code readability. 4) Expand Unit Testing. Add comprehensive unit tests specifically targetingCtxSettings
. 5)using MatchPredicate = std::function<std::optional<bool>(const pmtv::pmt &, const pmtv::pmt &, std::size_t)>;
replace this with the new matcher structure. See here for details.