fair-acc / gr-digitizers

GNU General Public License v3.0
3 stars 3 forks source link

Draft: Fix trigger threshold calculation for all scopes #88

Open alexxcons opened 2 years ago

alexxcons commented 2 years ago

The old calculation assumed that +5V always matches PSXXXX_MAX_VALUE, however that is only the case for the ps3000 digital inputs.

On all analog inputs, the values which matches PSXXXX_MAX_VALUE depends on the according range of the channel (ADC count)

(On AUX, the range is fixed to +/- 1V)

(This already was fixed for ps6000 in https://github.com/fair-acc/gr-digitizers/pull/86)

"Draft", because the changes build fine, but first need to be tested on all scope-types (check required voltage to actually trigger)

References (Check for method psXXXXSetSimpleTrigger ): https://www.picotech.com/download/manuals/picoscope-4000-series-a-api-programmers-guide.pdf https://www.picotech.com/download/manuals/PicoScope3000SeriesAApiProgrammersGuide.pdf https://www.picotech.com/download/manuals/picoscope-6000-series-programmers-guide.pdf