search

fair-acc / gr-digitizers

GNU General Public License v3.0
3 stars 3 forks source link

Log Error when Exception occurs during start/configure (Issue #95) #96

Closed alexxcons closed 2 years ago

alexxcons commented 2 years ago

In order to Make Configuration errors at least more visible

I did not find out whats the consequence of returning "false" in start, seems to make no difference.

I suppose Fesa should check d_configure_exception_message and stop/abort the flowgraph when it is filled.

Fixes https://github.com/fair-acc/gr-digitizers/issues/95

alexxcons commented 2 years ago

I did some more experimenting on it. Meanwhile I think best thing to do is to just call stop on the block, so that it stops running:

https://github.com/fair-acc/gr-digitizers/pull/96/commits/a4e6abaf56c44de85071754077a5a2596042eeb8

Seems to work fine (The result will be that FESA starts to complain that no data is received after few seconds)

Added the comment only to the first return, to dont duplicate it, and modified it to tell what I found out so far.

@RalphSteinhagen , @wirew0rm suppose that is fine for you ?

alexxcons commented 2 years ago

Merged, thank you for review !