search

fair-acc / gr-digitizers

GNU General Public License v3.0
3 stars 3 forks source link

Tags added to wrong channel if channels are disabled #99

Closed alexxcons closed 2 years ago

alexxcons commented 2 years ago

Was only wrong for streaming mode, works fine for triggered mode(Rapid Block)

Primary an issue to display the trigger-input-channel for ps3000 scopes (triggered by digital ports) if channels are disabled.

Possibly related: https://github.com/fair-acc/gr-digitizers/issues/80

Tested with dal011 (HF Streaming System on which Channels C and D are disabled)

alexxcons commented 2 years ago

Thanks dor review! merging

alexxcons commented 2 years ago

Meh, sorry, I just realized that I failed the port calculation whenever the trigger comes from an analog source (aichan starts by 0, not by 1).

I did not want to bother you with yet another MR for such a minimal change, so I just directly fixed it. Hope you dont mind: https://github.com/fair-acc/gr-digitizers/commit/e462a6aae2c70f23741ccd4139607ecbfd076a99,