fair-acc / opencmw-cpp

Open Common Middle-Ware library for accelerator equipment- and beam-based control systems at FAIR.
https://opencmw.io
GNU Lesser General Public License v3.0
10 stars 7 forks source link

Client context emscripten support #312

Closed wirew0rm closed 10 months ago

wirew0rm commented 1 year ago

PR just to trigger the CI, to see whether the emscripten errors are fixed and it can be incorporated into #300. I also added a small dns_example binary to be able to test the emscripten client against a native dns service which is not easily possible in the current testing framework.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 54.05% and project coverage change: +55.82 :tada:

Comparison is base (2c93a9b) 0.00% compared to head (2995bae) 55.82%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #312 +/- ## ========================================= + Coverage 0 55.82% +55.82% ========================================= Files 0 69 +69 Lines 0 7423 +7423 Branches 0 2728 +2728 ========================================= + Hits 0 4144 +4144 - Misses 0 1523 +1523 - Partials 0 1756 +1756 ``` | [Impacted Files](https://app.codecov.io/gh/fair-acc/opencmw-cpp/pull/312?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fair-acc) | Coverage Δ | | |---|---|---| | [src/client/include/RestClientNative.hpp](https://app.codecov.io/gh/fair-acc/opencmw-cpp/pull/312?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fair-acc#diff-c3JjL2NsaWVudC9pbmNsdWRlL1Jlc3RDbGllbnROYXRpdmUuaHBw) | `46.37% <0.00%> (ø)` | | | [src/core/include/ThreadAffinity.hpp](https://app.codecov.io/gh/fair-acc/opencmw-cpp/pull/312?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fair-acc#diff-c3JjL2NvcmUvaW5jbHVkZS9UaHJlYWRBZmZpbml0eS5ocHA=) | `59.57% <ø> (ø)` | | | [...disruptor/include/disruptor/ConsumerRepository.hpp](https://app.codecov.io/gh/fair-acc/opencmw-cpp/pull/312?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fair-acc#diff-c3JjL2Rpc3J1cHRvci9pbmNsdWRlL2Rpc3J1cHRvci9Db25zdW1lclJlcG9zaXRvcnkuaHBw) | `52.00% <0.00%> (ø)` | | | [.../disruptor/include/disruptor/EventHandlerGroup.hpp](https://app.codecov.io/gh/fair-acc/opencmw-cpp/pull/312?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fair-acc#diff-c3JjL2Rpc3J1cHRvci9pbmNsdWRlL2Rpc3J1cHRvci9FdmVudEhhbmRsZXJHcm91cC5ocHA=) | `80.00% <ø> (ø)` | | | [...disruptor/RoundRobinThreadAffinedTaskScheduler.hpp](https://app.codecov.io/gh/fair-acc/opencmw-cpp/pull/312?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fair-acc#diff-c3JjL2Rpc3J1cHRvci9pbmNsdWRlL2Rpc3J1cHRvci9Sb3VuZFJvYmluVGhyZWFkQWZmaW5lZFRhc2tTY2hlZHVsZXIuaHBw) | `60.52% <ø> (ø)` | | | [src/serialiser/include/IoSerialiser.hpp](https://app.codecov.io/gh/fair-acc/opencmw-cpp/pull/312?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fair-acc#diff-c3JjL3NlcmlhbGlzZXIvaW5jbHVkZS9Jb1NlcmlhbGlzZXIuaHBw) | `54.65% <ø> (ø)` | | | [src/services/include/services/dns.hpp](https://app.codecov.io/gh/fair-acc/opencmw-cpp/pull/312?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fair-acc#diff-c3JjL3NlcnZpY2VzL2luY2x1ZGUvc2VydmljZXMvZG5zLmhwcA==) | `31.81% <31.81%> (ø)` | | | [src/services/include/services/dns\_storage.hpp](https://app.codecov.io/gh/fair-acc/opencmw-cpp/pull/312?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fair-acc#diff-c3JjL3NlcnZpY2VzL2luY2x1ZGUvc2VydmljZXMvZG5zX3N0b3JhZ2UuaHBw) | `51.51% <51.51%> (ø)` | | | [src/services/include/services/dns\_types.hpp](https://app.codecov.io/gh/fair-acc/opencmw-cpp/pull/312?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fair-acc#diff-c3JjL3NlcnZpY2VzL2luY2x1ZGUvc2VydmljZXMvZG5zX3R5cGVzLmhwcA==) | `58.33% <58.33%> (ø)` | | | [src/client/include/ClientContext.hpp](https://app.codecov.io/gh/fair-acc/opencmw-cpp/pull/312?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fair-acc#diff-c3JjL2NsaWVudC9pbmNsdWRlL0NsaWVudENvbnRleHQuaHBw) | `55.31% <66.66%> (ø)` | | | ... and [3 more](https://app.codecov.io/gh/fair-acc/opencmw-cpp/pull/312?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fair-acc) | | ... and [56 files with indirect coverage changes](https://app.codecov.io/gh/fair-acc/opencmw-cpp/pull/312/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fair-acc)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

sonarcloud[bot] commented 11 months ago

SonarCloud Quality Gate failed.    Quality Gate failed

Bug D 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 52 Code Smells

No Coverage information No Coverage information
2.4% 2.4% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

wirew0rm commented 10 months ago

this PR was never expected to be merged and is incorporated into #300 which has since been merged