Fix subscription topic handling

frankosterfeld commented 1 year ago

Ensure that a client subscription "/service?a=b" arrives in the worker as such, and not as "/service".
Ensure that clients subscriptions "/service?a&b" and "/service?b&a" are treated the same, i.e. that the params are sorted alphabetically when passed to ZMQ.

codecov[bot] commented 1 year ago

Codecov Report

Attention: 52 lines in your changes are missing coverage. Please review.

Comparison is base (74ab5d1) 56.08% compared to head (4e54204) 56.02%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #323 +/- ## ========================================== - Coverage 56.08% 56.02% -0.06% ========================================== Files 69 70 +1 Lines 7398 7404 +6 Branches 2722 2726 +4 ========================================== - Hits 4149 4148 -1 - Misses 1485 1490 +5 - Partials 1764 1766 +2 ``` | [Files](https://app.codecov.io/gh/fair-acc/opencmw-cpp/pull/323?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fair-acc) | Coverage Δ | | |---|---|---| | [src/majordomo/include/majordomo/RestBackend.hpp](https://app.codecov.io/gh/fair-acc/opencmw-cpp/pull/323?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fair-acc#diff-c3JjL21ham9yZG9tby9pbmNsdWRlL21ham9yZG9tby9SZXN0QmFja2VuZC5ocHA=) | `22.36% <ø> (ø)` | | | [...ajordomo/include/majordomo/SubscriptionMatcher.hpp](https://app.codecov.io/gh/fair-acc/opencmw-cpp/pull/323?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fair-acc#diff-c3JjL21ham9yZG9tby9pbmNsdWRlL21ham9yZG9tby9TdWJzY3JpcHRpb25NYXRjaGVyLmhwcA==) | `77.14% <100.00%> (+15.07%)` | :arrow_up: | | [src/client/include/MockServer.hpp](https://app.codecov.io/gh/fair-acc/opencmw-cpp/pull/323?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fair-acc#diff-c3JjL2NsaWVudC9pbmNsdWRlL01vY2tTZXJ2ZXIuaHBw) | `59.67% <33.33%> (+1.23%)` | :arrow_up: | | [src/majordomo/include/majordomo/Worker.hpp](https://app.codecov.io/gh/fair-acc/opencmw-cpp/pull/323?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fair-acc#diff-c3JjL21ham9yZG9tby9pbmNsdWRlL21ham9yZG9tby9Xb3JrZXIuaHBw) | `55.06% <50.00%> (-0.18%)` | :arrow_down: | | [src/client/include/Client.hpp](https://app.codecov.io/gh/fair-acc/opencmw-cpp/pull/323?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fair-acc#diff-c3JjL2NsaWVudC9pbmNsdWRlL0NsaWVudC5ocHA=) | `42.36% <0.00%> (ø)` | | | [src/majordomo/include/majordomo/Broker.hpp](https://app.codecov.io/gh/fair-acc/opencmw-cpp/pull/323?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fair-acc#diff-c3JjL21ham9yZG9tby9pbmNsdWRlL21ham9yZG9tby9Ccm9rZXIuaHBw) | `53.19% <22.22%> (-0.11%)` | :arrow_down: | | [src/core/include/SubscriptionTopic.hpp](https://app.codecov.io/gh/fair-acc/opencmw-cpp/pull/323?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fair-acc#diff-c3JjL2NvcmUvaW5jbHVkZS9TdWJzY3JpcHRpb25Ub3BpYy5ocHA=) | `52.11% <52.11%> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/fair-acc/opencmw-cpp/pull/323/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fair-acc)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.