fair-acc / opencmw-cpp

Open Common Middle-Ware library for accelerator equipment- and beam-based control systems at FAIR.
https://opencmw.io
GNU Lesser General Public License v3.0
10 stars 8 forks source link

removed RxCpp dependency -> obsoleted by GR 4.0 #327

Closed RalphSteinhagen closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (be867a6) 56.01% compared to head (c85b313) 55.84%. Report is 1 commits behind head on main.

:exclamation: Current head c85b313 differs from pull request most recent head 68032c1. Consider uploading reports for the commit 68032c1 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #327 +/- ## ========================================== - Coverage 56.01% 55.84% -0.17% ========================================== Files 70 69 -1 Lines 7404 7291 -113 Branches 2726 2691 -35 ========================================== - Hits 4147 4072 -75 + Misses 1489 1484 -5 + Partials 1768 1735 -33 ``` | [Files](https://app.codecov.io/gh/fair-acc/opencmw-cpp/pull/327?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fair-acc) | Coverage Δ | | |---|---|---| | [src/client/include/Client.hpp](https://app.codecov.io/gh/fair-acc/opencmw-cpp/pull/327?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fair-acc#diff-c3JjL2NsaWVudC9pbmNsdWRlL0NsaWVudC5ocHA=) | `42.69% <63.15%> (+0.32%)` | :arrow_up: | ... and [4 files with indirect coverage changes](https://app.codecov.io/gh/fair-acc/opencmw-cpp/pull/327/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fair-acc)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 1 year ago

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

60.0% 60.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint