Closed ablepharus closed 8 months ago
Attention: Patch coverage is 17.77778%
with 37 lines
in your changes are missing coverage. Please review.
Project coverage is 57.03%. Comparing base (
a7a7c5c
) to head (2bd9294
).
Files | Patch % | Lines |
---|---|---|
src/client/include/RestClientNative.hpp | 21.62% | 5 Missing and 24 partials :warning: |
...c/client/include/RestDefaultClientCertificates.hpp | 0.00% | 7 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Failed conditions
22.4% Coverage on New Code (required ≥ 80%)
51.0% Duplication on New Code (required ≤ 3%)
Implement https subscriptions and fix a bug related to our handling regarding the https client.
Https subscriptions were just not handled, initialise a client and reuse the existing code for http subscriptions. There was a bug in our certificate store handling. The SSLClient owns its certificate store and deletes it on destruction. We can not share one store with all clients, so every client gets its own now.