search

fair-acc / opencmw-cpp

Open Common Middle-Ware library for accelerator equipment- and beam-based control systems at FAIR.
https://opencmw.io
GNU Lesser General Public License v3.0
10 stars 8 forks source link

Https subscription and root certs #341

Closed ablepharus closed 9 months ago

ablepharus commented 9 months ago

Implement https subscriptions and fix a bug related to our handling regarding the https client.

Https subscriptions were just not handled, initialise a client and reuse the existing code for http subscriptions. There was a bug in our certificate store handling. The SSLClient owns its certificate store and deletes it on destruction. We can not share one store with all clients, so every client gets its own now.

codecov[bot] commented 9 months ago

Codecov Report

Attention: Patch coverage is 17.77778% with 37 lines in your changes are missing coverage. Please review.

Project coverage is 57.03%. Comparing base (a7a7c5c) to head (2bd9294).

Files Patch % Lines
src/client/include/RestClientNative.hpp 21.62% 5 Missing and 24 partials :warning:
...c/client/include/RestDefaultClientCertificates.hpp 0.00% 7 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #341 +/- ## ========================================== - Coverage 57.15% 57.03% -0.13% ========================================== Files 69 69 Lines 7310 7324 +14 Branches 2703 2710 +7 ========================================== - Hits 4178 4177 -1 - Misses 1322 1324 +2 - Partials 1810 1823 +13 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 9 months ago

Quality Gate Failed Quality Gate failed

Failed conditions
22.4% Coverage on New Code (required ≥ 80%)
51.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud