search

fair-acc / opencmw-cpp

Open Common Middle-Ware library for accelerator equipment- and beam-based control systems at FAIR.
https://opencmw.io
GNU Lesser General Public License v3.0
10 stars 8 forks source link

implement deletion of dns entries and REST api for it #342

Closed ablepharus closed 9 months ago

codecov[bot] commented 9 months ago

Codecov Report

Attention: Patch coverage is 59.18367% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 57.02%. Comparing base (a7a7c5c) to head (af4eef1). Report is 1 commits behind head on main.

Files Patch % Lines
src/services/include/services/dns_client.hpp 52.17% 0 Missing and 11 partials :warning:
src/services/include/services/dns_storage.hpp 66.66% 2 Missing and 4 partials :warning:
src/services/include/services/dns.hpp 40.00% 0 Missing and 3 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #342 +/- ## ========================================== - Coverage 57.15% 57.02% -0.14% ========================================== Files 69 69 Lines 7310 7360 +50 Branches 2703 2728 +25 ========================================== + Hits 4178 4197 +19 - Misses 1322 1325 +3 - Partials 1810 1838 +28 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

frankosterfeld commented 9 months ago

Context: this is needed to unregister signals in the opendigitizer service, when the signal metadata of a sink changes, or when the whole flow graph is replaced.

frankosterfeld commented 9 months ago

besides unregister vs. delete wording preference, looks good to me

sonarcloud[bot] commented 9 months ago

Quality Gate Failed Quality Gate failed

Failed conditions
49.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud