Lift strict pin on bagit==1.6.4

mvdbeek commented 5 years ago

As bagit==1.6.4 can't be installed (by pip) on python 3:

root@e5e36d3697a2:/# pip install bdbag
Collecting bdbag
  Downloading https://files.pythonhosted.org/packages/53/c1/c28ec526b699813287f94cd4b9971918881505ecb1e7760a3a0fa8d9bf9c/bdbag-1.4.1-py2.py3-none-any.whl (63kB)
    100% |################################| 71kB 838kB/s
Collecting certifi (from bdbag)
  Using cached https://files.pythonhosted.org/packages/7c/e6/92ad559b7192d846975fc916b65f667c7b8c3a32bea7372340bfe9a15fa5/certifi-2018.4.16-py2.py3-none-any.whl
Collecting bagit==1.6.4 (from bdbag)
  Using cached https://files.pythonhosted.org/packages/64/91/4363e2d56a81431ef7b86cd8f0a530a5729032f207eb3b756eb29b4ed282/bagit-1.6.4.tar.gz
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-install-k6o0335t/bagit/setup.py", line 19, in <module>
        long_description = readme.read()
      File "/galaxy_venv3/lib/python3.6/encodings/ascii.py", line 26, in decode
        return codecs.ascii_decode(input, self.errors)[0]
    UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 1111: ordinal not in range(128)

    ----------------------------------------
Command "python setup.py egg_info" failed with error code 1 in /tmp/pip-install-k6o0335t/bagit/

This has been fixed on 1.7.0.

mvdbeek commented 5 years ago

This hadn't been caught in the tests because python setup.py install actually works.

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 168

0 of 0 changed or added relevant lines in 0 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.2%) to 83.841%

Files with Coverage Reduction	New Missed Lines	%
bdbag/init.py	2	78.03%
<!--	Total:	2		-->

Totals
Change from base Build 167:	0.2%
Covered Lines:	991
Relevant Lines:	1182

Pull Request Test Coverage Report for Build 168

0 of 0 changed or added relevant lines in 0 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.2%) to 83.841%

Files with Coverage Reduction	New Missed Lines	%
bdbag/init.py	2	78.03%
<!--	Total:	2		-->

Totals
Change from base Build 167:	0.2%
Covered Lines:	991
Relevant Lines:	1182

Pull Request Test Coverage Report for Build 168

0 of 0 changed or added relevant lines in 0 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.2%) to 83.841%

Files with Coverage Reduction	New Missed Lines	%
bdbag/init.py	2	78.03%
<!--	Total:	2		-->

Totals
Change from base Build 167:	0.2%
Covered Lines:	991
Relevant Lines:	1182

Pull Request Test Coverage Report for Build 169

0 of 0 changed or added relevant lines in 0 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.2%) to 83.841%

Files with Coverage Reduction	New Missed Lines	%
bdbag/init.py	2	78.03%
<!--	Total:	2		-->

Totals
Change from base Build 167:	0.2%
Covered Lines:	991
Relevant Lines:	1182

💛 - Coveralls

mvdbeek commented 5 years ago

@mikedarcy Sorry for being a bit impatient, could you have a look at this please ?

mikedarcy commented 5 years ago

I'm sorry I wasn't able to look into this sooner. I somehow did not get the email notification from GitHub when you first filed the PR.

I cannot seem to reproduce this using Python 3.6. Not quite sure what is going on. Could you run this pip command to bypass your cache and reinstall all deps?

pip install --force-reinstall --no-cache-dir --upgrade bdbag

Can you provide me some more info about your platform? Can you reproduce this consistently on other systems? I use Python3 by default and have not encountered this on the multiple systems I've installed the software to via Pip. What Pip version is being used?

In any case there next release of bdbag will probably be next week, and it will pin to 1.7.0. Unfortunately, the way the software is written against bagit requires monkeypatching so we pin it to a specific version. I don't think that will change anytime soon but we will bump the dep version with the next release.

mikedarcy commented 5 years ago

Aha, are you running in a docker container with minimal locale support? I think you've hit the issue referenced in this bagit commit, which indeed appears to fix the issue in 1.7.0.

Can you work around this for a bit until the next bdbag release when we move to bagit-1.7.0?

mvdbeek commented 5 years ago

Aha, are you running in a docker container with minimal locale support? I think you've hit the issue referenced in this bagit commit, which indeed appears to fix the issue in 1.7.0.

Indeed, and I was wondering how come I can't reproduce this anymore! Sure, the workaround is fine.

fair-research / bdbag