fair-research / bdbag

Big Data Bag Utilities
https://fair-research.org
Apache License 2.0
49 stars 23 forks source link

Add missing import. Fixes #31 #32

Closed Xarthisius closed 5 years ago

Xarthisius commented 5 years ago

Fetch transport for globus was missing an import.

fetch_globus.py:76:23: F821 undefined name 'ensure_valid_output_path'
coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 246


Totals Coverage Status
Change from base Build 244: 0.0%
Covered Lines: 1449
Relevant Lines: 1565

💛 - Coveralls
mikedarcy commented 5 years ago

Oops. Sorry about this. It would have been caught if there were better unit tests for Globus Transfer. Those are problematic because of all of the machinery involved. However, I will look into doing some mock invocations into the module which certainly would have caught an import issue like this one.