search

fair-research / bdbag

Big Data Bag Utilities
https://fair-research.org
Apache License 2.0
50 stars 22 forks source link

Fixes auth config validation for Globus fetch #48

Closed craig-willis closed 2 years ago

craig-willis commented 2 years ago

Fetching via globus gives the following error in 1.6.3 because validate_auth_config() is not expecting auth to be an OrderedDict. This PR hopefully fixes that.

For example:

$ pip3 freeze | grep bdbag
bdbag==1.6.3

$ cat fetch.txt
globus://82f1b5c6-6e9b-11e5-ba47-22000b92c6ec//published/publication_113/data/metadata.json 
    4475 data/data/data/metadata.json

$ bdbag --resolve-fetch all .

2022-02-11 13:13:02,557 - INFO - Attempting to resolve remote file references from fetch.txt.
2022-02-11 13:13:02,599 - ERROR - Globus Transfer request exception: [AttributeError] 'collections.OrderedDict' 
    object has no attribute 'auth_params'
2022-02-11 13:13:02,599 - INFO - Fetch complete. Elapsed time: 0:00:00.041566
coveralls commented 2 years ago

Coverage Status

Coverage remained the same at 95.866% when pulling 8df35490426e9b506a2b59529663f47b3a14cb58 on craig-willis:fix-globus-validate-config into 48519045836e0cdccb254b4613090f224c556d66 on fair-research:master.