search

fair-research / native-login

Provides Native App login and token storage for multiple providers
Apache License 2.0
3 stars 2 forks source link

Native Client App Name cannot be reset #45

Closed NickolausDS closed 3 years ago

NickolausDS commented 5 years ago

When the following is run: 

app = NativeClient(client_id='...', app_name='My App')
app.login()

The app name, "My App" is displayed on the local server page, but cannot be changed after it has been set the first time. This won't work, for example:

app = NativeClient(client_id='...', app_name='My Missplelled App')
app.login()
app = NativeClient(client_id='...', app_name='My App')
app.login()

Will result in "My Missplelled App" being displayed a second time. The problem is here: https://github.com/fair-research/native-login/blob/develop/fair_research_login/local_server.py#L88

Additionally, setting app_name doesn't appear to be well documented in examples.

Thanks @jgaff for finding this.

NickolausDS commented 3 years ago

Won't Fix. This hasn't been a problem the last two years, since it hasn't really been common usage to change the name of the app while it's running. Moreover, invoking login() multiple times in the same instance is rare, not commonly seen outside of Globus Flows.

Closing this for now. If someone sees it as a problem I'm happy to revisit it.