fair-research / native-login

Provides Native App login and token storage for multiple providers
Apache License 2.0
3 stars 2 forks source link

feat!: Remove save-revocation feature #75

Closed NickolausDS closed 2 years ago

NickolausDS commented 2 years ago

Originally FRL had a feature to ensure that only tokens tracked within token storage would be allowed to be live, and if those tokens were replaced that the old ones would be revoked out of caution. This causes unintended problems for any multiple instances of Globus SDK service clients which attempt to use the same set of tokens, especially in multi-threaded or multi-process environments. The first client to renew its tokens will make the other clients tokens inoperable.

As far as I know, this feature always caught people by surprise, and also hasn't provided tangible benefits, and so it will be removed. Users can continue to revoke their current set of saved tokens by calling logout(), or by going to https://app.globus.org/account/consents

BREAKING CHANGE: Old tokens replaced by new tokens from login will no longer be revoked.