search

fair-search / fairsearch-fair-for-elasticsearch

Fair search elasticsearch plugin
Apache License 2.0
14 stars 3 forks source link

M table generator new (from master) #17

Closed tsuehr closed 6 years ago

tsuehr commented 6 years ago

-Created a new branch from master -Implemented JUnit Tests for MTableGenerator

purbon commented 6 years ago

I would recommend you to check the tests, see

:forbiddenApisMain
:forbiddenApisTestForbidden annotation use: org.junit.Test [defaultMessage Just name your test method testFooBar]
  in com.purbon.search.fair.MTableGeneratorTest (MTableGeneratorTest.java, annotation on method declaration of 'computeMTableWithValidParametersTest()')
Forbidden annotation use: org.junit.Test [defaultMessage Just name your test method testFooBar]
  in com.purbon.search.fair.MTableGeneratorTest (MTableGeneratorTest.java, annotation on method declaration of 'initializeWithInvalidKValueTest()')
Forbidden annotation use: org.junit.Test [defaultMessage Just name your test method testFooBar]
  in com.purbon.search.fair.MTableGeneratorTest (MTableGeneratorTest.java, annotation on method declaration of 'initializeWithInvalidNValueTest()')
Forbidden annotation use: org.junit.Test [defaultMessage Just name your test method testFooBar]
  in com.purbon.search.fair.MTableGeneratorTest (MTableGeneratorTest.java, annotation on method declaration of 'initializeWithInvalidPValueTest()')
Forbidden annotation use: org.junit.Test [defaultMessage Just name your test method testFooBar]
  in com.purbon.search.fair.MTableGeneratorTest (MTableGeneratorTest.java, annotation on method declaration of 'initializeWithInvalidAlphaValueTest()')
Scanned 3 class file(s) for forbidden API invocations (in 0.08s), 5 error(s).
 FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':forbiddenApisTest'.
> de.thetaphi.forbiddenapis.ForbiddenApiException: Check for forbidden API calls failed, see log.

elasticsearch uses as a styleguide the forbiddenapis (https://github.com/policeman-tools/forbidden-apis/wiki) to assure good code practices. I think error is straightforward, but if you get questions don't hesitate to ask 😄 good work!

purbon commented 6 years ago

@tsuehr I created https://github.com/tsuehr/fairsearch-elasticsearch-plugin/pull/1 to amend the current complaints in your test. If you merge them we can move forward and merge this pr 😄

good work!

tsuehr commented 6 years ago

I will look at the style guide

purbon commented 6 years ago

LGTM, :shipit:

good work, next step the alpha correction function 😸