search

fair-software / howfairis-github-action

GitHub Action to analyze a GitHub repository’s compliance with the fair-software.eu recommendations.
Apache License 2.0
15 stars 5 forks source link

Use URL of repository #20

Closed c-martinez closed 3 years ago

c-martinez commented 3 years ago

This PR modifies the action to take REPOSITORY as an input and passes it to howfairis script.

jspaaks commented 3 years ago

Hi @c-martinez, is it OK with you if I update this branch a bit so it is in line with the recent updates we did on master?

c-martinez commented 3 years ago

Hey @jspaaks -- yes, please go ahead.

jspaaks commented 3 years ago

Crikey this was a pain, but I think it works now. Entrypoint etc like Edidiong suggested, so users can still run the container like docker run -ti howfairis https://github.com/owner/repo

I changed to passing the full URL BTW

Also, I'm now installing howfairis with pip using a git link in anticipation of the badge repo splitting off into a repo for just the action, and another for the howfairis python package.

The counterpart to this PR in badge-test is https://github.com/fair-software/badge-test/pull/4

Once merged, we should update some links to url branch, e.g.

jspaaks commented 3 years ago

Could you take another look at this @c-martinez ? Thanks!

c-martinez commented 3 years ago

Looks good to me -- thanks @jspaaks for all the updates. Can we merge it now?

jspaaks commented 3 years ago

Looks good to me -- thanks @jspaaks for all the updates. Can we merge it now?

Yes please go ahead a press the green button