Some valid ORCIDs do not match the regex check

fair-workflows / nanopub

Python client for searching, publishing and modifying nanopublications.

https://fair-workflows.github.io/nanopub

Apache License 2.0

22 stars 7 forks source link

Some valid ORCIDs do not match the regex check #119

Closed raar1 closed 3 years ago

raar1 commented 3 years ago

From a prospective user of the library:

hi, i got stuck setting up my nanopub profile because my ORCID does not
match the regex. I think the regex should be : ORCID_ID_REGEX = r'^https://orcid.org/(\d|X{4}-){3}\d|X{4}$' to allow for the Xes"

ORCIDs can end with an "X" instead of a number.

This is somehow because the last digit is a checksum.

raar1 commented 3 years ago

Fixed by PR #121