search

fairDataSociety / blossom

Browser Extension based on Fair Data Protocol
Apache License 2.0
5 stars 4 forks source link

feat: add signer #91

Closed tomicvladan closed 1 year ago

tomicvladan commented 2 years ago

Basic implementation of a signer.

nugaon commented 2 years ago

the default signer should be the default (application's) POD's signer. Later we can have a parameter for the pod name in order to get other POD's signer (that is not possible currently since dapps only access their own PODs).

tomicvladan commented 2 years ago

The signer has been updated with pod signer instead.

nugaon commented 2 years ago

I had two errors on npm run test

 FAIL  test/dapp-library.spec.ts (58.237 s)
  ● Dapp interaction with Blossom, using the library › fdp-storage tests › Should successfully create a pod

    ProtocolError: Protocol error (Runtime.callFunctionOn): Target closed

=======
  ● Dapp interaction with Blossom, using the library › Signer tests › Should sign a message

    TypeError: Cannot read properties of undefined (reading 'waitForSelector')

      21 |
      22 | export async function getElementBySelector(page: Page, selector: string): Promise<ElementHandle<Element>> {
    > 23 |   await page.waitForSelector(selector)

Though I had to do manual action at the confirmation

tomicvladan commented 2 years ago

Tests are passing on CI. That error must be related to some local issue. Could you check the stack trace of this error?