search

fairDataSociety / fdp-contracts

Fair Data Protocol smart contracts and its utilities
4 stars 1 forks source link

Username length limitation #155

Open tamas6 opened 1 year ago

tamas6 commented 1 year ago 
          @tamas6 move this issue to fdp-storage then please.

Originally posted by @crtahlin in https://github.com/fairDataSociety/fdp-create-account/issues/243#issuecomment-1576598861

tamas6 commented 1 year ago

I was unable to create ‘accountSep’ Due to “Invalid username” error

@.staging. 🤷🏻‍♂️

IgorShadurin commented 10 months ago

The error comes from fdp-contracts https://github.com/fairDataSociety/fdp-contracts/blob/ab1708a548ac42671a6a6f19175144e7d0cd2725/js-library/src/utils/domains.ts#L16

and then handled in fdp-create-account https://github.com/fairDataSociety/fdp-create-account/blob/ac19102228038d64afc72e1881210e93695c7e62/src/pages/register/username-password.tsx#L98

tamas6 commented 10 months ago

First goal is to inform user the password is invalid due to not knowing the parameters of a correct password. So let's show it them under the field. "Invalid Password" in red is now a bit a scary