fix: pennsieve agent check in advanced features cannot differentiate uninstalled from not running agent states

aaronm-2112 commented 1 month ago

Summary by Sourcery

Fix the Pennsieve agent check to correctly identify uninstalled and not running states. Enhance error handling and UI feedback for Pennsieve agent operations, including adding mutation observers and updating error messages with documentation links.

Bug Fixes:

Fix the Pennsieve agent check in advanced features to correctly differentiate between uninstalled and not running agent states.

Enhancements:

Improve error handling and logging for Pennsieve agent operations, including stopping, deleting database files, and restarting the agent.
Add mutation observers to monitor changes in the Pennsieve agent check status and update the UI accordingly.
Enhance the user interface to provide clearer feedback on the status of the Pennsieve agent, including messages for installation status and error conditions.

Documentation:

Update the Pennsieve agent error message display to include a link to the SODA documentation for troubleshooting.

fairdataihub-bot[bot] commented 1 month ago

Thank you for submitting this pull request! We appreciate your contribution to the project. Before we can merge it, we need to review the changes you've made to ensure they align with our code standards and meet the requirements of the project. We'll get back to you as soon as we can with feedback. Thanks again!

sourcery-ai[bot] commented 1 month ago

Reviewer's Guide by Sourcery

This pull request addresses an issue with the Pennsieve agent check in advanced features, specifically its inability to differentiate between uninstalled and not running agent states. The changes primarily focus on improving the user interface and error handling related to the Pennsieve agent check process.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change	Details	Files
Enhanced Pennsieve agent check functionality	Added a new button to confirm dataset selection before agent check Implemented a mutation observer to monitor agent check status Added error handling for agent check process Improved UI feedback during agent check process	`src/renderer/src/scripts/advanced-features/advanced_features.js` `src/renderer/src/components/backgroundServices/PennsieveAgentCheckDisplay/index.jsx` `src/renderer/src/sections/advanced-features/advanced_features.html`
Improved error handling and user guidance	Updated error message handling for UserSettings-related errors Added link to SODA documentation for manual issue resolution Implemented function to delete Pennsieve agent DB files and restart the agent	`src/renderer/src/components/backgroundServices/PennsieveAgentCheckDisplay/index.jsx`
Refactored banner image upload process	Added Pennsieve agent check before banner image upload Updated transition logic for banner image upload process Modified HTML structure to accommodate new agent check step	`src/renderer/src/scripts/others/tab-effects.js` `src/renderer/src/sections/advanced-features/advanced_features.html` `src/renderer/src/assets/component-utils/addDatasetAndOrganizationCards.js`
Updated manifest generation process	Added visibility toggle for confirm button in manifest generation Implemented new button for pulling manifest information	`src/renderer/src/scripts/metadata-files/manifest.js` `src/renderer/src/sections/advanced-features/advanced_features.html`

Tips and commands

#### Interacting with Sourcery - **Trigger a new review:** Comment `@sourcery-ai review` on the pull request. - **Continue discussions:** Reply directly to Sourcery's review comments. - **Generate a GitHub issue from a review comment:** Ask Sourcery to create an issue from a review comment by replying to it. - **Generate a pull request title:** Write `@sourcery-ai` anywhere in the pull request title to generate a title at any time. #### Customizing Your Experience Access your [dashboard](https://app.sourcery.ai) to: - Enable or disable review features such as the Sourcery-generated pull request summary, the reviewer's guide, and others. - Change the review language. - Add, remove or edit custom review instructions. - Adjust other review settings. #### Getting Help - [Contact our support team](mailto:support@sourcery.ai) for questions or feedback. - Visit our [documentation](https://docs.sourcery.ai) for detailed guides and information. - Keep in touch with the Sourcery team by following us on [X/Twitter](https://x.com/SourceryAI), [LinkedIn](https://www.linkedin.com/company/sourcery-ai/) or [GitHub](https://github.com/sourcery-ai).

fairdataihub-bot[bot] commented 1 month ago

Thanks for making updates to your pull request. Our team will take a look and provide feedback as soon as possible. Please wait for any GitHub Actions to complete before editing your pull request. If you have any additional questions or concerns, feel free to let us know. Thank you for your contributions!