fairdataihub / codefair-app

Your coding assistant to make research software reusable without breaking a sweat!
https://codefair.io
MIT License
4 stars 2 forks source link

✨ feat: add front end support for cwl validation #41

Closed megasanjay closed 1 month ago

fairdataihub-bot[bot] commented 1 month ago

Thank you for submitting this pull request! We appreciate your contribution to the project. Before we can merge it, we need to review the changes you've made to ensure they align with our code standards and meet the requirements of the project. We'll get back to you as soon as we can with feedback. Thanks again!

sourcery-ai[bot] commented 1 month ago

🧙 Sourcery has finished reviewing your pull request!


Tips - Trigger a new Sourcery review by commenting `@sourcery-ai review` on the pull request. - Continue your discussion with Sourcery by replying directly to review comments. - You can change your review settings at any time by accessing your [dashboard](https://app.sourcery.ai): - Enable or disable the Sourcery-generated pull request summary or reviewer's guide; - Change the review language; - You can always [contact us](mailto:support@sourcery.ai) if you have any questions or feedback.
what-the-diff[bot] commented 1 month ago

PR Summary

Refactoring of CardCollapsible.vue

The changes in this file will make our collapsible card components more reliable. By tying the collapse state to properties rather than a default state, user interaction with these components will be more predictable.

Duplication Removed in license/[identifier].vue

Cleaning up redundancy here aids future code modifications and promotes readability and understanding.

Enhancements to dashboard/[owner]/[repo].vue

Introducing a new reference for tracking validation loading state, a method for rerunning validation, fixes in timestamp calculation, and the addition of a component for handling validation, we are inherently making validation management on the dashboard more efficient and user-friendly.

Addition of view/cwl-validation/[identifier].vue

We've now got a new feature that allows fetching and displaying the specifics about a validation request. This gives more transparency to our users about the validation process.

Update on error messages

We've refined error status messages across several files (codeMetadata/[identifier]/index.post.ts, codeMetadata/[identifier]/index.put.ts, license/[identifier]/index.post.ts, license/[identifier]/index.put.ts, license/request/[licenseid].get.ts). These changes make our error messaging clearer and more informative.

New Routes in API

Implemented new endpoints for fetching CWL validation request details (cwlValidation/[identifier]/index.get.ts) and for triggering a rerun of a validation request (cwlValidation/[identifier]/rerun.post.ts). With these additions, you can better manage your requests.

Dashboard Data Extended

The dashboard's response data now contains details about the CWL validation request. More data visibility for you.

Introduction of cwlValidation.d.ts

The new file is for type definitions. It's helping developers by specifying the types of values, enhancing code reliability and predictability.

fairdataihub-bot[bot] commented 1 month ago

Thanks for closing this pull request! If you have any further questions, please feel free to open a new issue. We are always happy to help!