search

fairdk / lcrs-embedded

LCRS embedded components - "slave" + embedded linux kernel
https://lcrs.fairdanmark.dk/
GNU General Public License v3.0
1 stars 3 forks source link

Improve PEP8 compliance + better indentation #10

Closed piratepieter closed 7 years ago

piratepieter commented 7 years ago

@benjaoming Some small aesthetic changes to warm up :)

codecov[bot] commented 7 years ago

Codecov Report

Merging #10 into master will decrease coverage by 0.08%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #10      +/-   ##
==========================================
- Coverage   95.61%   95.52%   -0.09%     
==========================================
  Files          19       20       +1     
  Lines         752      782      +30     
==========================================
+ Hits          719      747      +28     
- Misses         33       35       +2
Impacted Files Coverage Δ
lcrs_embedded/system/battery.py 95% <ø> (ø) :arrow_up:
lcrs_embedded/utils/models.py 100% <0%> (ø) :arrow_up:
lcrs_embedded/system/cpu_load.py 93.1% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d037fdb...5de1b68. Read the comment docs.

benjaoming commented 7 years ago

Could you make the PR just with the small PEP8 fix and not the indentation stuff?

piratepieter commented 7 years ago

Don't you like the textwrap module? It has been a PyMOTW. My editor and I love it.

benjaoming commented 7 years ago

I'm not loving that we introduce a convention to indent text strings and then un-indent them again.. it has extra processing, and then what if someone doesn't use textwrap around a multi-line text string? Should we add a rule in the docs about it? Add a git commit hook to check that it doesn't happen? Write a CI integration that scans the code? If it was a PEP8 thing, it'd be nice, but this is more like an odd decoration of code that will be counter-productive in the overall course of time.