fairdk / lcrs-embedded

LCRS embedded components - "slave" + embedded linux kernel
https://lcrs.fairdanmark.dk/
GNU General Public License v3.0
1 stars 3 forks source link

Add function that generates CPU load, third attempt #8

Closed jvilladsen closed 7 years ago

jvilladsen commented 7 years ago

Add a test of the timed CPU load from within the same process so that this is picked up in test coverage. Measure duration in timed CPU load and test as float. Processor load status field added to the scan result.

codecov[bot] commented 7 years ago

Codecov Report

Merging #8 into master will decrease coverage by 0.22%. The diff coverage is 93.1%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #8      +/-   ##
==========================================
- Coverage   95.86%   95.63%   -0.23%     
==========================================
  Files          19       20       +1     
  Lines         773      779       +6     
==========================================
+ Hits          741      745       +4     
- Misses         32       34       +2
Impacted Files Coverage Δ
lcrs_embedded/system/cpu_load.py 93.1% <93.1%> (ø)
lcrs_embedded/utils/models.py 100% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e2cf3c3...a7cc68b. Read the comment docs.

benjaoming commented 7 years ago

@jvilladsen sorry about the code review fuzz - is this ready to merge? or are you continuing work in this branch?

benjaoming commented 7 years ago

@jvilladsen is it ready?

jvilladsen commented 7 years ago

It is ready as it is. I began on a (minor) change to create a process for each thread, but we can take that later.