search

fairecasoimeme / ZiGate

Zigate is an Universal Zigbee Gateway
http://zigate.fr
171 stars 59 forks source link

Develco VOC Sensor Support #313

Closed schrodingersket closed 3 years ago

schrodingersket commented 4 years ago

Completes #284

Note that the new Climax/Develco clusters are NOT added to any coordinator endpoints by default; this pull request only adds support for them to be optionally added. Once cluster instances are shared across multiple endpoints for various manufacturers, these manufacturer-specific clusters should be added to endpoints unique to Climax and Develco to maintain better code modularity (see #310 ).

Additionally, new macros have been added to zcl_options.h in order to conditionally register manufacturer endpoints; all previous endpoints are enabled, so this PR introduces zero change in current functionality.

pipiche38 commented 3 years ago

I think @badzz submitted a PR which remove the restriction on Manufacturer Specific. In such all Manufacturer Specific are now accepted. In addition if a message/command is not handle by the firmware, the message is send to the above layer (plugin for example) via the Data Indication 0x8002 to be process.

schrodingersket commented 3 years ago

I think @badzz submitted a PR which remove the restriction on Manufacturer Specific. In such all Manufacturer Specific are now accepted. In addition if a message/command is not handle by the firmware, the message is send to the above layer (plugin for example) via the Data Indication 0x8002 to be process.

I'm not sure how I never saw this update, but since there's no restriction on Manufacturer Specific clusters and other messages are passed to the host, I will close this issue pull request and corresponding issue.