search

fairfield-programming / backend-server

📠 The backend of the Fairfield Programming Association website.
https://fairfieldprogramming.org/
MIT License
26 stars 13 forks source link

Cleaned up code #118

Closed ghost closed 2 years ago

ghost commented 2 years ago

I do not have the time to format the rest, so I would like someone else to. Following the same async/await pattern would be a good idea.

MassiGy commented 2 years ago

Hey @supernova350,

You did a really good job refactoring and cleaning up the code. I like how you escape the callback hell with async/await. I will also try to do more of that.

Thanks. Massiles.

MassiGy commented 2 years ago

I've just cloned your git repo @supernova350, and I see that you've changed the jobs code a bit. Did you test it ?

Thanks. Massiles.

ghost commented 2 years ago

I am 99% sure that the accountCleanup job is working. @MassiGy

MassiGy commented 2 years ago

Okey, that is fair enough. I will retest it when @William-McGonagle or @NeilChaudhari merge the remaining PRs.

Massiles.

MassiGy commented 2 years ago

Hey there @William-McGonagle,

Yeah no problem, I am currently working on this PR. I'am fixing the merge conflicts and in my current version of code I still have the Prettierrc file.

I will submit a new PR soon, which will be the fixed version of this one, thanks again to @supernova350.

Hope that was clear. Massiles.

MassiGy commented 2 years ago

Hey everyone.

I will close this one since the PR #119 wraps it, and solve the current merge conflicts.

Hope that is clear. Massiles.