Types && Model fixes - Githubissues

fairfield-programming / backend-server

📠 The backend of the Fairfield Programming Association website.

https://fairfieldprogramming.org/

MIT License

26 stars 13 forks source link

Types && Model fixes #128

Closed Lucky-victory closed 2 years ago

Lucky-victory commented 2 years ago

what I did.

Fixed the type annotation issues, and changed the initial Request and Response types to those from Express.

Extended Express Request object, and added user to the req object

I also removed the Models from the global object and exported them instead since it was causing a bug.

MassiGy commented 2 years ago

Hey there @Lucky-victory,

Could you please fix the merge conflicts and also remove the extension added to the express.Request object for simplicity.

Cuz, express itself allows you to chain whatever you want to the Request/Response objects. Even though, it is a great idea from you, but for simplicity sake and for new comers, removing it will more natural.

Thanks in advance. Massiles.

Lucky-victory commented 2 years ago

Ok, let me do that right away.

MassiGy commented 2 years ago

This PR should not be merged for a few reasons.

Event modal name is set to Events instead of Event.
The modals are not imported in all files.
The added extension to the express request object is not removed.

You are welcome to fire up a new PR with these issues fixed.

Hope that is clear. Massiles.