search

fairnessforensics / wiggum

simpson's paradox inspired fairness forensics
https://fairnessforensics.github.io/wiggum/
MIT License
5 stars 3 forks source link

Ability to close detail view window #128

Closed darbycobb closed 4 years ago

darbycobb commented 4 years ago

There are some readability issues because you cannot close the detail view after you open it, and it blocks the right side of some of the matrices. image

brownsarahm commented 4 years ago

@Shine226 I think it would be nice if the detail view panel could be closed and/or resized (as per #84 ) and the overview matrices could fill the whole space when the detail view is closed.

At a minimum, the detail view needs to be small enough to not overlap before we can do the userstudy

Shine226 commented 4 years ago

I made the detail view scalable when the window is resized, it solves the overlap issue.

brownsarahm commented 4 years ago

@Shine226 did you commit that directly to master?

Shine226 commented 4 years ago

@brownsarahm I am about making new PR for this if you also think we can close this issue.

cegme commented 4 years ago

Looks a lot better, the only strange issue are the appearance (or missing) scroll bars. It is hard to tell whether more scrolling is actually needed. It would also be good to be aligned if possible. image

Shine226 commented 4 years ago

The length of the table in the bottom will be changed depending on the datasets. For some datasets, the table may only under the heat map matrix view, but for some datasets, the table will under both matrices view and detail view.

Shine226 commented 4 years ago

I changed the div size for the table view as the same as the matrices view size. But now user need to scroll horizontally to read the most-right part if the table length exceeds the div length. Screen Shot 2019-12-09 at 5 13 06 PM

brownsarahm commented 4 years ago

I think we should avoid horizontal scroll on the table as much as possible. allowing it to be the full width. But, we can make that scroll bar be to the right of the detail plot to make it neater?

Some padding on the detail plot could help with the visual separation, or maybe even lightweight, light colored borders with titles for the sections?

Shine226 commented 4 years ago

I tried add the borders, but it didn't look great. It is weird that the legend for heatmap is outside of the boarder of the heat map. Screen Shot 2019-12-10 at 12 12 59 PM

cegme commented 4 years ago

This looks a lot better to me. You could probably remove the border for the parallel coordinate plot. Maybe add some small internal padding in the main window.

Shine226 commented 4 years ago

How about this one? Is the internal padding in the matrices view good? The slider for table will go the almost right-most of the window, since the table' width is 78% of the whole window, and margin left for the table is 20%. Screen Shot 2019-12-10 at 1 14 57 PM

Shine226 commented 4 years ago

I adjusted the position for each matrix in the cell. Now it will look like below. Screen Shot 2019-12-10 at 1 41 28 PM