fairtracks / fairtracks_standard

FAIRtracks is a JSON Schema defining a minimal standard for genomic track metadata.
https://fairtracks.net
Creative Commons Attribution 4.0 International
7 stars 2 forks source link

Update biomaterial_type #15

Closed sveinugu closed 4 years ago

sveinugu commented 5 years ago

From https://github.com/orgs/fairtracks/teams/fairtracks-developers/discussions/14

This is directly from IHEC: https://github.com/IHEC/ihec-metadata/blob/master/specs/Ihec_metadata_specification.md#samples, and is a controlled vocabulary of:

The choice of biomaterial_type has direct impacts on what to use in sample_type. "Primary tissue" would lead to e.g. "Brain" as sample_type, while "Cell line" would lead to e.g. "H1-hESC". It could perhaps be called sample category, or similar.

sveinugu commented 4 years ago

Fixed in https://github.com/fairtracks/fairtracks_standard/pull/20