search

fairtracks / fairtracks_validator

FAIRification of Genomic Data Tracks JSON Schema validator
GNU Lesser General Public License v2.1
0 stars 0 forks source link

Make prefix validation case sensitive #2

Closed sveinugu closed 4 years ago

sveinugu commented 5 years ago

In order to tighten up the JSON schema. Seems to already be case sensitive validation in the JAVA code

sveinugu commented 5 years ago

I have not tested the changes

jmfernandez commented 5 years ago

Hi @sveinugu , I have just read RFC 3986, which is about URIs (all the CURIEs are URIs). The RFC states that the scheme declaration (aka the prefix) is case insensitive, so a prefix with some or all the letters in capitals should be valid, and identified as the same in lowercase.

As the standard also recommends to write URIs with the scheme in lowercase, we can decide whether to enforce that recommendation or not.

sveinugu commented 5 years ago

@jmfernandez Thanks for the thorough research. Yes I think we should enforce the recommendation of lowercase prefixes. Supporting all variants will only leads to duplicated contents with slight variations, even though the values are equal. Which only leads to downstream issues. No need to allow this, IMO.