search

fairvotereform / RankIt

https://rankit.vote
1 stars 2 forks source link

Embed results-only after poll is closed #104

Closed ggordn3r closed 4 years ago

ggordn3r commented 4 years ago

Currently the embed works for voting, but VCMA requests being able to embed results without the ability to vote. Is this already "built in" more or less when voting is closed on a poll? I think the logic is fairly straightforward: when the poll is closed, the embed goes straight to results.

iambateman commented 4 years ago

The challenge here is that the embed is just a small version of the vote page, so how it works on the app is how it needs to work on the embed.

iambateman commented 4 years ago

But we can probably figure out a way to do this.

iambateman commented 4 years ago

not probably. can.

proggeramlug commented 4 years ago

this can now be tested, I'll provide a dev-URL shortly

ggordn3r commented 4 years ago

I embedded this on a hidden page on Koios to test out. See https://www.koios.co/settings

I am using this poll: https://rankit.skelpo.com/polls/h2rjTQZMM4PYtsDAbQZv

I saw a "voting has concluded" message for a split-second, but as soon as I clicked "View Results", I always see this on reload: Screenshot (253)

That is a problem because the person viewing didn't actually vote. Insted, the results-only embed should start on the "Final Results" screen:

Screenshot (254)

proggeramlug commented 4 years ago

Replace "https://rankit.vote/" with "https://rankit.skelpo.com/" and it _should_work ;) You embedded the live version, which doesn't have this update (yet).