fairvotereform / RankIt

https://rankit.vote
1 stars 2 forks source link

Firebase Analytics not recording data #111

Closed ggordn3r closed 4 years ago

ggordn3r commented 4 years ago

Something is wrong with the Google Analytics setup for RankIt--it's not logging any data. I think Stephen just missed the step about adding the Analytics SDK to the . Analytics SDK guide here: https://firebase.google.com/docs/analytics/get-started?platform=web#add_the_sdk_to_your_app

proggeramlug commented 4 years ago

Trey, I need some more information here on what you are expecting. :) It looks like this is roughly set up and should be working but since you don't see anything I wonder what you expect to see where and why it is not showing up.

Has this ever worked? Can you send me screenshots or URLs of what you did see in the past?

ggordn3r commented 4 years ago

No problem. Log in to the Firebase console and scroll down the left menu until you see "Analytics". There's a message implying that setup isn't complete and no data showing up. I tried moving the date range around and as far as I can tell it has never recorded anything.

On Fri, Apr 24, 2020, 05:57 Ralph Küpper notifications@github.com wrote:

Assigned #111 https://github.com/iambateman/RankIt/issues/111 to @ggordn3r https://github.com/ggordn3r.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/iambateman/RankIt/issues/111#event-3268710032, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACNMYBH3XSBNWVBPRFX6P53ROFPBTANCNFSM4MNS3VZA .

ggordn3r commented 4 years ago

To help you troubleshoot, here's where I'm looking: https://console.firebase.google.com/u/0/project/rankit-vote/analytics/app/web:ZjE3NTc4YmEtNTNhYy00ZDlkLWJmNzYtMTZkNjQxMmQ2ZDYx/overview/~2F%3Ft%3D1587945987045&fpn%3D961061092759&swu%3D1&sgu%3D1&sus%3Dupgraded&cs%3Dapp.m.dashboard.overview&g%3D1

And here's what I see:

image

proggeramlug commented 4 years ago

I think I found the problem and fixed it - test it :)

ggordn3r commented 4 years ago

Confirmed! I'm seeing data now. One more thing--we got this warning message from Google yesterday. I looked at it and it appears to be related to this issue. @proggeramlug can you fix this before I close it?

Dear Customer,

We have detected a publicly accessible Google API key associated with the following Google Cloud Platform project: Project rankit (id: rankit-vote) with API key AIzaSyCQ79C1szqKVaoPBIxUGbLIZix-5CVcwXs The key was found at the following URL: https://github.com/iambateman/RankIt/blob/978e14121627408b696c84dac4decc2567a9f988/src/environments/environment.prod.ts

We believe that you or your organization may have inadvertently published the affected API key in public sources or on public websites (for example, credentials mistakenly uploaded to a service such as GitHub.)Please note that as the project/account owner, you are responsible for securing your keys. Therefore, we recommend that you take the following steps to remedy this situation:

If this key is intended to be public (or if a publicly accessible key isn’t preventable): Log in to the Google Cloud Console and review the API and billing activity on your account, ensuring the usage is in line with what you expected. Add API key restrictions to your API key, if applicable.

If this key was NOT meant to be public: Regenerate the compromised API key: Search for Credentials in the cloud console platform, Edit the leaked key, and use the Regenerate Key button to rotate the key.

For more details, review the instructions on handling compromised GCP credentials. Take immediate steps to ensure that your API key(s) are not embedded in public source code systems, stored in download directories, or unintentionally shared in other ways. Add API key restrictions to your API key, if applicable. The security of your Google Cloud Platform account(s) is important to us.

proggeramlug commented 4 years ago

I was about to answer your email about this issue. The key has been public in this repository for months already. Me committing to this file just triggered Github (and Google by extension) to warn us of this fact. But what I added did not add to this insecure fact already.

Best solution: Make this repository private, which GitHub does not allow (since it is a fork). We could move all this content to a private repository and run it that way - thoughts?

ggordn3r commented 4 years ago

The client wants this to be an open-source project, which is why we chose the public repository. What's the second-best solution? :D

proggeramlug commented 4 years ago

Okay, the second one is more annoying but I went through it: Rewrite the history of git (since this is versioned we need to actually rewrite the history of this repository). I have done that and the files are removed.

However, they are still cached (which is why you can still access them via the browser). I contacted Github support to renew the cache and then we should be through with this.

(I've done this before in case you are wondering :D :D )

ggordn3r commented 4 years ago

Haha, we appreciate your experience! Closing.