fairvotereform / RankIt

https://rankit.vote
1 stars 2 forks source link

Missing default Call-To-Action #129

Closed ggordn3r closed 4 years ago

ggordn3r commented 4 years ago

In the last release, we had a default call to action if the poll creator didn't select one. It said "Bring RCV to Your Community" and linked to https://www.fairvote.org/get_involved. Was it commented out in the code? It's no longer visible, but the page should still include it if no other CTA is selected.

proggeramlug commented 4 years ago

Found the problem and fixed it!

ggordn3r commented 4 years ago

Just tested with this URL on staging and I don't see the fix, even after a refresh with cache override: https://rankit.skelpo.com/vote/o6OhlgVOkaxmcSDy5WB1/success

Screenshot below.

Screenshot (352)

Update: Also tested this on rankit.vote and I think I'm seeing it on this poll. However, two small issues: 1) The CTA button's default color should always be the pink we use for buttons, not white, and the font color white, not black. This is true for custom CTAs as well (only super users adding custom branding can override this). 2) The URL isn't right. It currently links to https://www.fairvote.org/ but should link to https://www.fairvote.org/get_involved

Maybe you made the change there, but forgot to add it to staging?

proggeramlug commented 4 years ago

Fixed and available to test now!

ggordn3r commented 4 years ago

The URL isn't right. It currently links to https://www.fairvote.org/ but should link to https://www.fairvote.org/get_involved

Otherwise, looks good on staging!

proggeramlug commented 4 years ago

That's a caching problem - the URL is saved to the poll. New polls have the correct URL.

ggordn3r commented 4 years ago

Hmm... I just created a brand-new poll and it was still the old URL. See https://rankit.skelpo.com/vote/awqmxvFFf5NdWH4Jfzyc

proggeramlug commented 4 years ago

Fixed!

ggordn3r commented 4 years ago

Client made one tiny request on this that I didn't think deserved its own issue: The call-to-action button should open in a new tab by default. Current behavior is loads in same tab.

proggeramlug commented 4 years ago

True ;) Done!