search

fairvotereform / RankIt

https://rankit.vote
1 stars 2 forks source link

Custom branding: upload a logo #141

Open ggordn3r opened 4 years ago

ggordn3r commented 4 years ago

A user requested a file upload option for a logo in addition to the current URL option.

The implementation would be a simple "Upload" button. No choosing from images previously uploaded, no keeping track of who owns which images.

How long do you estimate it would take to implement this? Are there implications I'm overlooking?

proggeramlug commented 4 years ago

That's a solid few days of work. I'd think probably 2-3 days of work total. Picking from existing images is a bit of an issue here since it requires a lot of extra logic.

ggordn3r commented 4 years ago

Ok, let's scratch the idea to pick from existing images. What if there's just an "Upload" button for a logo as an alternative to URL? Is that feasible as a half-day project or less?

proggeramlug commented 4 years ago

Yep, half day is about right!

ggordn3r commented 4 years ago

Update: DO NOT complete yet. Waiting to hear back from client to see if we can avoid this through better documentation around Image URLs

Ok, let's move ahead with this then. This button should be in the same purple style as the "Save Poll" one at the bottom of /create.

ggordn3r commented 4 years ago

Client OK'd not adding this functionality and documenting how to use image URLs better instead.