Add prompt to enable results sharing after "Publish Poll" validation

ggordn3r commented 4 years ago

Several users have been confused by the new "hide results" feature and mistakenly submitted bug reports that their results weren't showing up.

To avoid this, we should add a dialog prompt after the current "Publish Poll" validation forcing users to explicitly choose whether their results will be held or shown.

Current Message after clicking "Publish Poll": "Are you sure? Once you publish a poll others will be able to see it and vote on it until you close the poll." OK / Cancel After "OK": [validation message]

New dialog box after the validation message: Text: "Do you want to show your results immediately after each vote, or hide them from voters until you close the poll? Choice A: Show results Choice B: Hide results

If user chooses "Show results"

Set results_public to True
Show dialog message: "Your results are visible. Voters in your poll will see the current results immediately after they cast their vote.

If user chooses "Hide results":

Set results_public to False
Show dialog message: "Your results are hidden. To show this poll's results later, click the toggle beside "Do not show votes publicly".

proggeramlug commented 4 years ago

Implemented!

ggordn3r commented 4 years ago

Close, but I'm seeing "Ok" and "Cancel" when the buttons should be "Show results" and "Hide results"

Is that possible, or do I need to reword the message for "Ok" and "Cancel" to make sense?

Screenshot (391)

proggeramlug commented 4 years ago

Quick solution: We can't choose the words. We could use another style of popup but I think we could just reword it too.

(other style of popup is more work to implement but it is possible)

ggordn3r commented 4 years ago

Ok, here's the rewording to use:

Text: Click "OK" to show your results immediately after each vote. Click "Cancel" to hide them from voters until you close the poll.

proggeramlug commented 4 years ago

Done

ggordn3r commented 4 years ago

Not quite, but close. See screenshots below.

The text I provided (Click "OK" to show your results immediately after each vote. Click "Cancel" to hide them from voters until you close the poll.) should be on the box that appears in this screenshot (i.e. the second box):

Screenshot (23)

For the final message (screenshot below), display this: If they clicked OK Your poll is published and ready to share. Voters will see results after they submit their vote. If they clicked Cancel Your poll is published and ready to share. Voters will not see results until/unless you choose to display them in your settings. Screenshot (24)

proggeramlug commented 4 years ago

Fixed!

fairvotereform / RankIt

Add prompt to enable results sharing after "Publish Poll" validation #148