Preview doesn't display custom colors

fairvotereform / RankIt

https://rankit.vote

1 stars 2 forks source link

Preview doesn't display custom colors #160

Closed ggordn3r closed 4 years ago

ggordn3r commented 4 years ago

The preview feature seems to be broken right now. See, for example, this poll: https://rankit.skelpo.com/results/VNQWkCqW8JIQuQ39NHFR/summary

I don't see any of the custom branding I chose.

Also, testers pointed out that the preview doesn't have buttons, so it can't show custom button colors. Can you add example buttons?

proggeramlug commented 4 years ago

Problem is that you forgot to include "#". Since this is probably more common than not I have included a check that will automatically add the symbol in code if needed.

ggordn3r commented 4 years ago

Thanks, I see the bar and font colors now. I see a "back to home page" button but it's not the class of button that shows custom colors. See description--to allow super users to review all their custom branding choices, we also need two buttons on this page (even if they don't do anything) that show button color 1 and button color 2.

Let's do this:

if is_published = false
Show a button that says "Button Color 1 Preview" with the button 1 class
Show a button that says "Button Color 2 Preview" with the button 2 class

proggeramlug commented 4 years ago

This is done now - note however that the poll referenced above is already published, so the condition does not apply here.

ggordn3r commented 4 years ago

Cool. I asked the client to retest.

ggordn3r commented 4 years ago

I created a new poll and added custom colors throughout but don't see the new preview buttons: https://rankit.skelpo.com/results/Ebu7i5FHENcT4YJ2m4Pg/summary

proggeramlug commented 4 years ago

Well, this poll is already published ...

ggordn3r commented 4 years ago

No, it's not:

proggeramlug commented 4 years ago

Ah, found the problem and fixed it!