fairvotereform / RankIt

https://rankit.vote
1 stars 2 forks source link

Save & publish button flow fails #166

Open ggordn3r opened 4 years ago

ggordn3r commented 4 years ago

On rankit.vote, I tried creating a new poll: https://rankit.vote/polls/ZQUzZdylS3vMPSwAQxQN

I saved it, then clicked "edit poll" and changed the number of winners and the label, then saved again. I clicked "edit poll" again and then clicked "Save & Publish". Instead of the expected "are you sure?" validation flow, the poll published instantly without opening or showing results:

image

I tested again, clicking "Save & Publish" right away after setting up the poll and it worked as expected: https://rankit.vote/polls/FB7Fq65KpCaQiS4zMwyW

proggeramlug commented 4 years ago

Problem found and fixed

ggordn3r commented 4 years ago

Now it shows the first "Are you sure?" box, but not the full sequence that asks about showing results. It also fails to open the poll: https://rankit.vote/polls/S0E7g8JCHhToNVLPv8ao

Expected behavior is a second validation box on click of "Save & Publish": Click "OK" to show your results immediately after each vote. Click "Cancel" to hide them from voters until you close the poll.

proggeramlug commented 4 years ago

Okay, I see it, fixed it.